This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Rename toGpuImage to toImageSync #34504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates documentation. Makes toImageSync work in software contexts.
jonahwilliams
approved these changes
Jul 7, 2022
lib/ui/painting/image_encoding.cc
Outdated
| if (pixmap.colorType() == color_type && pixmap.alphaType() == alpha_type) { | ||
| return SkData::MakeWithCopy(pixmap.addr(), pixmap.computeByteSize()); | ||
| } | ||
| // if (pixmap.colorType() == color_type && pixmap.alphaType() == alpha_type) { |
Contributor
Author
There was a problem hiding this comment.
Whups. Removed the stray log too.
Contributor
|
auto-submit
bot
removed
the
autosubmit
shell/common/rasterizer.cc
Outdated
| bool gpu_available = true; | ||
| delegate_.GetIsGpuDisabledSyncSwitch()->Execute( | ||
| fml::SyncSwitch::Handlers().SetIfTrue( | ||
| [&gpu_available] { gpu_available = false; })); |
Member
There was a problem hiding this comment.
Can we put the following logic into SyncSwitch's Handlers? I guess just using SyncSwitch to get the value of gpu_available is not enough.
Contributor
Author
There was a problem hiding this comment.
Yeah I'll have to refactor this. I realized after uploading
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates documentation.
Makes toImageSync work in software contexts.