Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Fix typo in FAQ #34495

Merged
auto-submit merged 1 commit into from
Jul 7, 2022
Merged

[Impeller] Fix typo in FAQ #34495

auto-submit merged 1 commit into from
Jul 7, 2022

Conversation

@creativecreatorormaybenot
Copy link
Contributor

@creativecreatorormaybenot creativecreatorormaybenot commented Jul 7, 2022

The sentence explaining why Skia is used for text rendering is confusing due to a typo. This PR fixes the typo and should make the explanation clear.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@creativecreatorormaybenot
Copy link
Contributor Author

creativecreatorormaybenot commented Jul 7, 2022

cc @chinmaygarde

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 7, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 7, 2022

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 7, 2022

Validations Fail.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 7, 2022
@chinmaygarde chinmaygarde changed the title Fix typo in Impeller FAQ [Impeller] Fix typo in FAQ Jul 7, 2022
@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 7, 2022
@auto-submit auto-submit bot merged commit 73ded8c into flutter:main Jul 7, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 7, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 7, 2022
@engine-flutter-autoroll
73ded8c [Impeller] Fix typo in FAQ (flutter/engine#34495)
aa799f6
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

@zanderso zanderso zanderso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller

Projects

No open projects
Impeller
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@creativecreatorormaybenot @chinmaygarde @zanderso