Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jason-simmons
Copy link
Member

Previously this script was using the size of the compressed PNG file.

Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skia-gold
Copy link

Gold has detected about 1 new digest(s) on patchset 1.
View them at https://flutter-engine-gold.skia.org/cl/github/34431

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #34431 at sha 3a34465

@jason-simmons
Copy link
Member Author

@jason-simmons
Copy link
Member Author

Updated the Skia Gold client to use a default differentPixelsRate of 1% (instead of 10%)

Allowing 1% of the image size to differ from the golden image should be appropriate now that the image size accurately reflects the pixel count of the uncompressed image.

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chinmaygarde
Copy link
Member

This needs to be rebased to run presubs again. But the expectation is that this is good to land.

… threshold in the Skia Gold scenario tests

Previously this script was using the size of the compressed PNG file.
@jason-simmons jason-simmons force-pushed the scenario_gold_pixel_count branch from 0fe8d53 to e2b1a52 Compare July 20, 2022 19:04
@skia-gold
Copy link

Gold has detected about 19 new digest(s) on patchset 1.
View them at https://flutter-engine-gold.skia.org/cl/github/34431

@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 20, 2022
@auto-submit auto-submit bot merged commit a0f389e into flutter:main Jul 20, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App will affect goldens

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants