-
Notifications
You must be signed in to change notification settings - Fork 6k
Use uncompressed image size as the basis for the fuzzy pixel matching threshold in the Skia Gold scenario tests #34431
Use uncompressed image size as the basis for the fuzzy pixel matching threshold in the Skia Gold scenario tests #34431
Conversation
zanderso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jonahwilliams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Gold has detected about 1 new digest(s) on patchset 1. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
3a34465 to
6f58917
Compare
6f58917 to
0fe8d53
Compare
|
Updated the Skia Gold client to use a default Allowing 1% of the image size to differ from the golden image should be appropriate now that the image size accurately reflects the pixel count of the uncompressed image. |
jonahwilliams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
This needs to be rebased to run presubs again. But the expectation is that this is good to land. |
… threshold in the Skia Gold scenario tests Previously this script was using the size of the compressed PNG file.
0fe8d53 to
e2b1a52
Compare
|
Gold has detected about 19 new digest(s) on patchset 1. |
…matching threshold in the Skia Gold scenario tests (flutter/engine#34431)
Previously this script was using the size of the compressed PNG file.