This repository was archived by the owner on Feb 25, 2025. It is now read-only.
New mozart input events. #3439
Merged
New mozart input events. #3439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abarth
reviewed
Feb 23, 2017
content_handler/runtime_holder.cc
Outdated
| if (keyboard->phase == mozart::KeyboardEvent::Phase::PRESSED) | ||
| type = "keydown"; | ||
| else if (keyboard->phase == mozart::KeyboardEvent::Phase::REPEAT) | ||
| type = "keydown"; |
Contributor
There was a problem hiding this comment.
Can you add a TODO to change this to "keyrepeat" ?
Contributor
|
|
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Mar 9, 2017
* New mozart input events. * Adding TODO for keyrepeat
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc abarth