Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Jun 29, 2022

Cherry pick for flutter/flutter#106523 . Manually verified with the example code that the artifacts are no longer present

@flutter-dashboard
Copy link

This pull request was opened against a branch other than main. Since Flutter pull requests should not normally be opened against branches other than main, I have changed the base to main. If this was intended, you may modify the base back to flutter-2.13-candidate.0. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than main, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard bot changed the base branch from flutter-2.13-candidate.0 to main June 29, 2022 23:16
@jonahwilliams jonahwilliams changed the base branch from main to flutter-2.13-candidate.0 June 29, 2022 23:16
@jonahwilliams
Copy link
Contributor Author

I had to change a lot more due to some churn from a separate layer caching change, so now this needs additional verification from me

@skia-gold
Copy link

Gold has detected about 1 new digest(s) on patchset 1.
View them at https://flutter-engine-gold.skia.org/cl/github/34385

@jonahwilliams jonahwilliams marked this pull request as ready for review June 30, 2022 00:15
MockCanvas::DrawCall{
1, MockCanvas::ClipRectData{layer_bounds, SkClipOp::kIntersect,
MockCanvas::kSoft_ClipEdgeStyle}},
#ifndef SUPPORT_FRACTIONAL_TRANSLATION
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were removed since the code to raster cache clips hasn't been added yet

@skia-gold
Copy link

Gold has detected about 8 new digest(s) on patchset 2.
View them at https://flutter-engine-gold.skia.org/cl/github/34385

@CaseyHillers CaseyHillers merged commit 9927f79 into flutter:flutter-2.13-candidate.0 Jun 30, 2022
@jonahwilliams jonahwilliams deleted the cherry_picks branch June 30, 2022 02:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants