Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@CaseyHillers
Copy link
Contributor

@CaseyHillers CaseyHillers commented Jun 29, 2022

Flutter stable 3.0.4 Engine

Scheduled Cherrypicks

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@CaseyHillers
Copy link
Contributor Author

CaseyHillers commented Jun 29, 2022

I'm going to drop 7aa848494 and request follow up from the author

@zanderso
Copy link
Member

I'm going to drop 7aa848494 and request follow up from the author

Can you explain a bit more?

@CaseyHillers CaseyHillers force-pushed the cherrypicks-flutter-2.13-candidate.0 branch from 84460c2 to 19ef1c4 Compare June 29, 2022 22:36
@CaseyHillers
Copy link
Contributor Author

I'm going to drop 7aa848494 and request follow up from the author

Can you explain a bit more?

The expected diff for that commit was ~100 LOC, but it pulled in ~1500 LOC when applied

@skia-gold
Copy link

Gold has detected about 8 new digest(s) on patchset 2.
View them at https://flutter-engine-gold.skia.org/cl/github/34382

@skia-gold
Copy link

Gold has detected about 8 new digest(s) on patchset 3.
View them at https://flutter-engine-gold.skia.org/cl/github/34382

Because we are unable to allocate address space without also allocating memory, even unused portions of the compressed heap make less memory available to all other allocators in the process. The memory savings in the compressed heap will only out-weight the lost memory for other allocations if nearly all of the application's memory usage is in Dart, rather than, say, graphics or plugins.

Bug: flutter/flutter#105183
Bug: b/235279083
@CaseyHillers CaseyHillers force-pushed the cherrypicks-flutter-2.13-candidate.0 branch from cbc51cd to 3d9fa4b Compare June 30, 2022 01:47
@CaseyHillers CaseyHillers merged commit e3c1546 into flutter:flutter-2.13-candidate.0 Jun 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants