This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix pre-push githooks on Windows and enable all format checks #34374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and fix the test issue on non-Windows
like the other format checkers
gspencergoog
approved these changes
Jul 13, 2022
Contributor
gspencergoog
left a comment
gspencergoog
left a comment
There was a problem hiding this comment.
Thanks for doing this! Just one nit.
| @@ -1,10 +0,0 @@ | |||
| #!/bin/sh | |||
Contributor
There was a problem hiding this comment.
Shouldn't this file be replaced with one that actually does the pre-push check? Or does just removing this run the general one instead?
Contributor
Author
There was a problem hiding this comment.
The original pre-push in tools/githooks works on all platforms now that Windows has all the checks working.
Granted people on Windows need to run gclient sync after this change to re-run tools/githooks/setup.py, which will modify the git config to use the common pre-push file on Windows. This will not be necessary on other platforms.
chinmaygarde
approved these changes
Jul 13, 2022
gspencergoog
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 13, 2022
betrevisan
pushed a commit
to betrevisan/engine
that referenced
this pull request
Jul 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable running the pre-push githook with all the format checkers on Windows, just like on other platforms.
This PR changes how you build the engine on Windows, so a change in the Wiki Compiling the engine is required, specifically in the "Compiling for Windows" section. The ninja build command needs to be changed to
ninja -d keeprsp -C .\out\<dir created by previous step>Issues fixed by this PR
Changes to flutter/tests
This PR does not affect flutter/tests
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.