This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add gen_snapshot for windows. #34304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
reviewed
Jun 27, 2022
shell/platform/android/BUILD.gn
Outdated
| # BUG: https://github.com/flutter/flutter/issues/105351 | ||
| zip_bundle("new_gen_snapshot") { | ||
| gen_snapshot_bin = "gen_snapshot" | ||
| gen_snapshot_path = rebase_path("$root_out_dir/clang_x64/$gen_snapshot_bin") |
Member
There was a problem hiding this comment.
I'd suggest getting this path from get_label_info(). Should be something like:
gen_snapshot_out_dir = get_label_info("//third_party/dart/runtime/bin:gen_snapshot($host_toolchain)", "root_out_dir")
rebase_path("$gen_snapshot_out_dir/$gen_snapshot_bin")This will make it easier to support compilation on arm64 Macs when it comes time for that since the host toolchain will put things under something like clang_arm64. It looks like a similar change would be helpful above in some other targets as well.
zanderso
approved these changes
Jul 1, 2022
godofredoc
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 1, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generates a gen_snapshot archive for windows. The reason it is a separate target is that names and paths are completely different and adding them to the same target will be confusing.
Bug: flutter/flutter#81855
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.