Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add gen_snapshot to flutter_gtk. #34287

Merged
auto-submit merged 1 commit into from
Jun 27, 2022
Merged

Add gen_snapshot to flutter_gtk. #34287

auto-submit merged 1 commit into from
Jun 27, 2022

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Jun 25, 2022

gen_snapshot is required as part of flutter_gtk.

Bug: flutter/flutter#81855

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Add gen_snapshot to flutter_gtk.
391a2a5 
gen_snapshot is required as part of flutter_gtk.

Bug: flutter/flutter#81855
@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 27, 2022
@auto-submit auto-submit bot merged commit 83a16dd into main Jun 27, 2022
@christopherfujino christopherfujino deleted the fix_flutter_gtk branch June 27, 2022 17:00
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 27, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 27, 2022
@engine-flutter-autoroll
83a16dd Add gen_snapshot to flutter_gtk. (flutter/engine#34287)
6c529d5
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

1 more reviewer

@zanderso zanderso zanderso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-linux

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@godofredoc @zanderso