Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[canvaskit] Correctly get the directionality of the text boxes #34264

Merged
harryterkelsen merged 7 commits into from
Jun 24, 2022
Merged

[canvaskit] Correctly get the directionality of the text boxes #34264

harryterkelsen merged 7 commits into from
Jun 24, 2022

Conversation

@harryterkelsen
Copy link
Contributor

@harryterkelsen harryterkelsen commented Jun 23, 2022

The old code assumed the directionality of the TextBoxes was the same as the Paragraph. The new code gets the directionality from CanvasKit (which it computes using Unicode data).

Fixes flutter/flutter#78550

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@harryterkelsen harryterkelsen requested a review from yjbanov June 23, 2022 22:35
@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Jun 23, 2022
kevmoo
kevmoo approved these changes Jun 23, 2022
View reviewed changes
@harryterkelsen
Copy link
Contributor Author

harryterkelsen commented Jun 23, 2022

I had to add an exception for canvaskit/text.dart to use dart:js_util because CanvasKit puts the direction property as a JS property on the Float32List. Raw JavaScript access is the only way to get at it.

yjbanov
yjbanov approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harryterkelsen harryterkelsen merged commit 9bc723b into flutter:main Jun 24, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 24, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 24, 2022
@engine-flutter-autoroll
9bc723b [canvaskit] Correctly get the directionality of the text boxes (
93ceaff 
flutter/engine#34264)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@kevmoo kevmoo kevmoo approved these changes

@yjbanov yjbanov yjbanov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform-web Code specifically for the web engine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[web][CanvasKit] TextField with TextDirection.rtl has misplaced cursor

3 participants

@harryterkelsen @kevmoo @yjbanov