Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Remove full platform name from patched_sdk path. #34258

Merged
auto-submit merged 2 commits into from
Jun 23, 2022
Merged

Remove full platform name from patched_sdk path. #34258

auto-submit merged 2 commits into from
Jun 23, 2022

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Jun 23, 2022 •
edited
Loading

flutter_patched_sdk is expected on the root folder by the flutter tool.

Bug: flutter/flutter#81855

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Add full platform name to the path of patched_sdk.
799f1fd 
The tool is expecting the file in a location including host platform and
cpu architecture.

Bug: flutter/flutter#81855
@godofredoc
Fix path to patched sdk.
f762ec7
@godofredoc godofredoc changed the title Add full platform name to the path of patched_sdk. Remove full platform name from patched_sdk path. Jun 23, 2022
christopherfujino
christopherfujino approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 23, 2022
@auto-submit auto-submit bot merged commit ccde9c8 into flutter:main Jun 23, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 24, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 24, 2022
@engine-flutter-autoroll
ccde9c8 Remove full platform name from patched_sdk path. (flutter/eng…
09578c1 
…ine#34258)
@godofredoc godofredoc deleted the add_plat_name branch January 12, 2024 19:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@keyonghan keyonghan Awaiting requested review from keyonghan

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@godofredoc @christopherfujino