This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Adds a flag to the gn script to build with -fstack-protector #34257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gold has detected about 1 new digest(s) on patchset 1. |
dnfield
approved these changes
Jun 23, 2022
Member
Author
|
@dnfield It looks like flutter/buildroot#580 is having trouble rolling in. What's the status of that? |
Contributor
|
I'm going to try to get #33814 landed today, if it takes longer than that I'll revert the buildroot patch and we can reland it later. |
Member
|
The linked Swangle patches should be unblocked. But, if not, the buildroot patch will be reverted. |
zanderso
force-pushed
the
stack-protector
branch
from
ffd8373 to
a50393d
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to help investigate flutter/flutter#87952
The new GN flag is added in flutter/buildroot#584