This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Pass --std=ios-metal1.2 only in opt mode
#34256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing this flag in unopt mode disables the debug symbols from being shown in xcode. fixes: flutter/flutter#106066
Member
|
Without these flags, the shader debugger works, but the xcode frame profiler always crashes for me. |
Contributor
Author
@bdero if you change it to |
chinmaygarde
approved these changes
Jun 23, 2022
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
LGTM. But given the Xcode instability, perhaps we should also add guidance on what toggles to try to make profiling and shader debugging work. Also, file a radar to followup.
chinmaygarde
changed the title
--std=ios-metal1.2 only in opt mode--std=ios-metal1.2 only in opt mode
fix format
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing this flag in unopt mode disables the debug symbols
from being shown in xcode.
fixes: flutter/flutter#106066