Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Make DisplayList DispatchHelpers prevent against extra restore calls #34247

Merged
auto-submit merged 3 commits into from
Jun 23, 2022
Merged

Make DisplayList DispatchHelpers prevent against extra restore calls #34247

auto-submit merged 3 commits into from
Jun 23, 2022

Conversation

@ColdPaleLight
Copy link
Member

@ColdPaleLight ColdPaleLight commented Jun 23, 2022 •
edited
Loading

fix flutter/flutter#100176

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@ColdPaleLight ColdPaleLight requested review from chinmaygarde and flar and removed request for flar June 23, 2022 09:43
flar
flar approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@flar flar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chinmaygarde chinmaygarde added waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. autosubmit Merge PR when tree becomes green via auto submit App labels Jun 23, 2022
@auto-submit auto-submit bot merged commit a9c6233 into flutter:main Jun 23, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 24, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 24, 2022
@engine-flutter-autoroll
a9c6233 Make DisplayList DispatchHelpers prevent against extra restor…
cb15c52 
…e calls (flutter/engine#34247)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

@flar flar flar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DisplayList DispatchHelpers should protect against extra restore calls

3 participants

@ColdPaleLight @chinmaygarde @flar