Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Reland [canvaskit] Rework platform views #34236

Merged
harryterkelsen merged 20 commits into from
Jun 22, 2022
Merged

Reland [canvaskit] Rework platform views #34236

harryterkelsen merged 20 commits into from
Jun 22, 2022

Conversation

@harryterkelsen
Copy link
Contributor

@harryterkelsen harryterkelsen commented Jun 22, 2022

Reland of #34081 with analysis error fix

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@harryterkelsen harryterkelsen requested a review from ditman June 22, 2022 20:36
@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Jun 22, 2022
ditman
ditman approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛬

@harryterkelsen harryterkelsen merged commit 2d3b16e into flutter:main Jun 22, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 24, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 24, 2022
@engine-flutter-autoroll
2d3b16e Reland [canvaskit] Rework platform views (flutter/engine#34236)
53a3a98
@maher1337
Copy link

maher1337 commented Jan 18, 2023

Any ETA for release?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@ditman ditman ditman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform-web Code specifically for the web engine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@harryterkelsen @maher1337 @ditman