This repository was archived by the owner on Feb 25, 2025. It is now read-only.
added trace events for scheduling responses to platform messages #34230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
reviewed
Jun 22, 2022
| FML_DCHECK(!*is_complete); | ||
| *is_complete = true; | ||
| uint64_t platform_message_id = platform_message_counter.fetch_add(1); | ||
| TRACE_EVENT_ASYNC_BEGIN1("flutter", "PlatformChannel:ScheduleResult", |
Contributor
There was a problem hiding this comment.
Suggested change
| TRACE_EVENT_ASYNC_BEGIN1("flutter", "PlatformChannel:ScheduleResult", | |
| TRACE_EVENT_ASYNC_BEGIN1("flutter", "PlatformChannel::ScheduleResult", |
Member
Author
There was a problem hiding this comment.
I didn't want to use the double colon since that denotes a c++ symbol. There isn't a c++ with this name. I wanted the 2 events that I'm adding to be associated with each other and I wanted them named the same across android and iOS since they are measuring the same thing. I don't want people to have to learn a new name for a different embedder.
Contributor
There was a problem hiding this comment.
Ahh in that case then I think the convention is just to use a space here instead of a : - like Scene display lagor Framework workload or whatever.
dnfield
reviewed
Jun 22, 2022
shell/platform/android/io/flutter/embedding/engine/dart/DartMessenger.java
Outdated
Show resolved
Hide resolved
Member
|
Friendly bump, is this waiting on another review from @dnfield? |
dnfield
approved these changes
Jul 13, 2022
dnfield
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 13, 2022
betrevisan
pushed a commit
to betrevisan/engine
that referenced
this pull request
Jul 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This measures the latency between thread hops when sending messages from Flutter->Host and responding Host->Flutter.
We have platform channel channel profiling on the framework side, but it can't determine how much of the round trip time is just the latency between scheduling on a thread and it actually getting serviced.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.