Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Android Autofill] Don't set autofillHints to an empty array when there's no autofillhints #34203

Merged
auto-submit merged 3 commits into from
Jun 24, 2022
Merged

[Android Autofill] Don't set autofillHints to an empty array when there's no autofillhints #34203

auto-submit merged 3 commits into from
Jun 24, 2022

Conversation

@LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Jun 21, 2022

Maybe fixes flutter/flutter#98505

stack trace:

E/AndroidRuntime(15779): java.lang.ArrayIndexOutOfBoundsException: length=0; index=0
E/AndroidRuntime(15779):    at com.samsung.android.smartsuggestions.assist.AssistStructureParser.getHint(AssistStructureParser.java:154)
E/AndroidRuntime(15779):    at com.samsung.android.smartsuggestions.assist.AssistStructureParser.addAutofillableFields(AssistStructureParser.java:54)
E/AndroidRuntime(15779):    at com.samsung.android.smartsuggestions.assist.AssistStructureParser.addAutofillableFields(AssistStructureParser.java:68)
E/AndroidRuntime(15779):    at com.samsung.android.smartsuggestions.assist.AssistStructureParser.addAutofillableFields(AssistStructureParser.java:68)
E/AndroidRuntime(15779):    at com.samsung.android.smartsuggestions.assist.AssistStructureParser.getAutofillableFields(AssistStructureParser.java:43)
E/AndroidRuntime(15779):    at com.samsung.android.smartsuggestions.assist.AssistStructureParser.getHint(AssistStructureParser.java:248)
E/AndroidRuntime(15779):    at com.samsung.android.smartsuggestions.services.AugmentedAutofillService.onFillRequest(AugmentedAutofillService.java:77)
E/AndroidRuntime(15779):    at android.service.autofill.augmented.AugmentedAutofillService.handleOnFillRequest(AugmentedAutofillService.java:284)
E/AndroidRuntime(15779):    at android.service.autofill.augmented.AugmentedAutofillService.access$200(AugmentedAutofillService.java:74)
E/AndroidRuntime(15779):    at android.service.autofill.augmented.AugmentedAutofillService$AugmentedAutofillServiceImpl.lambda$onFillRequest$2(AugmentedAutofillService.java:118)
E/AndroidRuntime(15779):    at android.service.autofill.augmented.-$$Lambda$AugmentedAutofillService$AugmentedAutofillServiceImpl$rg4bgWPXG7Diy30M48ekR52l-AY.accept(Unknown Source:40)
E/AndroidRuntime(15779):    at com.android.internal.util.function.pooled.PooledLambdaImpl.doInvoke(PooledLambdaImpl.java:423)
E/AndroidRuntime(15779):    at com.android.internal.util.function.pooled.PooledLambdaImpl.invoke(PooledLambdaImpl.java:201)
E/AndroidRuntime(15779):    at com.android.internal.util.function.pooled.OmniFunction.run(OmniFunction.java:97)
E/AndroidRuntime(15779):    at android.os.Handler.handleCallback(Handler.java:938)
E/AndroidRuntime(15779):    at android.os.Handler.dispatchMessage(Handler.java:99)
E/AndroidRuntime(15779):    at android.os.Looper.loop(Looper.java:246)
E/AndroidRuntime(15779):    at android.app.ActivityThread.main(ActivityThread.java:8456)
E/AndroidRuntime(15779):    at java.lang.reflect.Method.invoke(Native Method)
E/AndroidRuntime(15779):    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:596)
E/AndroidRuntime(15779):    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1130)

It seems Samsung smart suggestions is assuming the autofill hint list is always non-empty.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@chinmaygarde
Copy link
Member

chinmaygarde commented Jun 23, 2022

Can't tell if this is necessary. But seems like a decent guess based on the stack trace. Besides, the change itself is harmless.

@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 24, 2022
@auto-submit auto-submit bot merged commit b4367d9 into flutter:main Jun 24, 2022
@LongCatIsLooong LongCatIsLooong deleted the dont-set-autofillhints-for-empty-list branch June 24, 2022 01:30
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 24, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 24, 2022
@engine-flutter-autoroll
b4367d9 [Android Autofill] Don't set autofillHints to an empty array …
a096038 
…when there's no autofillhints (flutter/engine#34203)
chejdj pushed a commit to chejdj/engine that referenced this pull request Jul 20, 2022
@LongCatIsLooong @zhuyangyang-lingoace
[Android Autofill] Don't set autofillHints to an empty array when the…
1880579 
…re's no autofillhints (flutter#34203)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@chinmaygarde chinmaygarde chinmaygarde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Android][Samsung]: app throws SamsungSmartSuggestion stopped working error while opening and closing keyboard.

2 participants

@LongCatIsLooong @chinmaygarde