Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

cleanup fractional translation ifdefs and config #34198

Merged
jonahwilliams merged 3 commits into from
Jun 22, 2022
Merged

cleanup fractional translation ifdefs and config #34198

jonahwilliams merged 3 commits into from
Jun 22, 2022

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Jun 21, 2022

flutter/flutter#103909

Holding off on landing this until we confirm there are no major performance regressions from removing pixel snapping from mobile

@jonahwilliams jonahwilliams changed the title cleanup fractional translation ifdefs cleanup fractional translation ifdefs and config Jun 21, 2022
@skia-gold
Copy link

skia-gold commented Jun 21, 2022

Gold has detected about 1 new digest(s) on patchset 3.
View them at https://flutter-engine-gold.skia.org/cl/github/34198

@flutter-dashboard
Copy link

flutter-dashboard bot commented Jun 21, 2022

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #34198 at sha 4911bb9

@jonahwilliams jonahwilliams requested a review from dnfield June 21, 2022 21:11
dnfield
dnfield approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It would be ideal to make sure we haven't regressed customer:money's benchmarks with this change, although they're currently in a sad state. I'm not sure how long it will take to get that better, but we should reach out to them before landing this to make sure.

@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Jun 22, 2022

we can always re-revert 😄

@jonahwilliams jonahwilliams merged commit ddd1a51 into flutter:main Jun 22, 2022
@jonahwilliams jonahwilliams deleted the remove_if_defs branch June 22, 2022 16:01
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 22, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 22, 2022
@engine-flutter-autoroll
ddd1a51 cleanup fractional translation ifdefs and config (flutter/eng…
8487287 
…ine#34198)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

will affect goldens

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonahwilliams @skia-gold @dnfield