This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Make the GLFW embedder example work on Linux #34156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
approved these changes
Jun 23, 2022
betrevisan
approved these changes
Jun 24, 2022
Contributor
betrevisan
left a comment
betrevisan
left a comment
There was a problem hiding this comment.
LGTM. Thank you for fixing this issue!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#106221.
This patch makes GLFW use EGL instead of GLX on Linux, matching the Linux embedder's behavior.
Skia always attempts to use
eglGetCurrentDisplayto fetch the egl display and theneglQueryStringto fetch the extension list. However, when GLFW creates a GLX context, both of these procs exhibit non-standard behavior and return invalid, non-error, non-null values causing a crash when the extension list is dereferenced.The preprocessor guard is necessary because the EGL context can't be used on MacOS.