Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix path in android aot configuration. #34155

Merged
auto-submit merged 1 commit into from
Jun 21, 2022
Merged

Fix path in android aot configuration. #34155

auto-submit merged 1 commit into from
Jun 21, 2022

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Jun 18, 2022

it was using a release path for a profile build.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Fix path in android aot configuration.
5464e39 
it was using a release path for a profile build.
@godofredoc godofredoc requested a review from keyonghan June 18, 2022 04:53
keyonghan
keyonghan approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 21, 2022
@auto-submit auto-submit bot merged commit 39f0501 into flutter:main Jun 21, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 21, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 21, 2022
@engine-flutter-autoroll
39f0501 Fix path in android aot configuration. (flutter/engine#34155)
ae00277
@godofredoc godofredoc deleted the fix_aot branch January 12, 2024 19:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@keyonghan keyonghan keyonghan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@godofredoc @keyonghan