Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fixes for gn artifacts. #34152

Merged
auto-submit merged 2 commits into from
Jun 18, 2022
Merged

Fixes for gn artifacts. #34152

auto-submit merged 2 commits into from
Jun 18, 2022

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Jun 18, 2022

  • Adds a slash at the end of abi jars path.
  • Generates abi files for android_profile arm64.

Bug: flutter/flutter#81855

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Fixes for gn artifacts.
fc1771b 
* Adds a slash at the end of abi jars path.
* Generates abi files for android_profile arm64.

Bug: flutter/flutter#81855
@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 18, 2022
@auto-submit auto-submit bot merged commit c0c31a1 into main Jun 18, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2022
@engine-flutter-autoroll
c0c31a1 Fixes for gn artifacts. (flutter/engine#34152)
bccd243
houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
@godofredoc @houhuayong
Fixes for gn artifacts. (flutter#34152)
c817cd8
@chinmaygarde chinmaygarde deleted the fixes_linux_artifacts branch July 6, 2022 06:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

@keyonghan keyonghan Awaiting requested review from keyonghan

1 more reviewer

@XilaiZhang XilaiZhang XilaiZhang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-android platform-linux

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@godofredoc @XilaiZhang