Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Keyboard] Mark generated file names with infix .g. #34123

Merged
dkwingsmt merged 4 commits into from
Jun 24, 2022
Merged

[Keyboard] Mark generated file names with infix .g. #34123

dkwingsmt merged 4 commits into from
Jun 24, 2022

Conversation

@dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented Jun 16, 2022 •
edited
Loading

This PR accompanies flutter/flutter#106142 by changing the names of the auto-generated files to contain infix .g., hopefully making it more obvious that they should not be directly modified.

The Android files are excluded because of Java's naming convention.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added embedder Related to the embedder API platform-ios platform-linux platform-macos platform-web Code specifically for the web engine platform-windows labels Jun 16, 2022
@dkwingsmt dkwingsmt mentioned this pull request Jun 16, 2022
Merged
8 tasks
@dkwingsmt dkwingsmt force-pushed the mark-generated-files branch from e8925cd to 203fce2 Compare June 16, 2022 23:46
This was referenced Jun 17, 2022
Merged
Closed
@dkwingsmt dkwingsmt changed the title [Keyboard] Mark generated files with .g. [Keyboard] Mark generated file names with infix .g. Jun 21, 2022
@dkwingsmt dkwingsmt requested a review from gspencergoog June 22, 2022 22:45
gspencergoog
gspencergoog approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@dkwingsmt dkwingsmt merged commit a5788f9 into flutter:main Jun 24, 2022
@dkwingsmt dkwingsmt deleted the mark-generated-files branch June 24, 2022 03:02
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 24, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 24, 2022
@engine-flutter-autoroll
a5788f9 [Keyboard] Mark generated file names with infix .g. (flutte…
c81b96e 
…r/engine#34123)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@gspencergoog gspencergoog gspencergoog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

embedder Related to the embedder API platform-ios platform-linux platform-macos platform-web Code specifically for the web engine platform-windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dkwingsmt @gspencergoog