This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Keyboard, Android] Mint physical keys on the Android plane #34122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

The Android keyboard embedder responder has to mint physical keys from logical keys when the scan code is empty, and currently it does so onto a new plane called "logical plane".
This PR makes it mint physical keys onto the existing Android plane instead. This avoids creating a new plane just for this purpose and aligns with how other platforms behave.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.