Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Make the cmake GLFW embedder example easier to use #34113

Merged
bdero merged 4 commits into from
Jun 16, 2022
Merged

Make the cmake GLFW embedder example easier to use #34113

bdero merged 4 commits into from
Jun 16, 2022

Conversation

@bdero
Copy link
Member

@bdero bdero commented Jun 16, 2022 •
edited
Loading

  • Simplify the process of getting the GLFW example running by just using the GLFW dependency checkout. The GLFW CMake build is quite stable and simple across mac/linux/windows.
  • When building the bundle, use the local engine configuration so that the correct Dart kernel binary will get roped in.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Jun 16, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@chinmaygarde chinmaygarde added waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. and removed waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. labels Jun 16, 2022
@bdero bdero changed the title Build GLFW from source in the cmake GLFW example Make the cmake GLFW embedder example easier to use Jun 16, 2022
betrevisan
betrevisan approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@betrevisan betrevisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bdero for fixing this! It should make the process of running these examples much smoother.

@bdero bdero merged commit a308832 into flutter:main Jun 16, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2022
@engine-flutter-autoroll
a308832 Make the cmake GLFW embedder example easier to use (flutter/e…
3b3cebf 
…ngine#34113)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2022
@engine-flutter-autoroll
a308832 Make the cmake GLFW embedder example easier to use (flutter/e…
6e81c20 
…ngine#34113)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2022
@engine-flutter-autoroll
a308832 Make the cmake GLFW embedder example easier to use (flutter/e…
ca9fceb 
…ngine#34113)
houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
@bdero @houhuayong
Make the cmake GLFW embedder example easier to use (flutter#34113)
630f741
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

@gaaclarke gaaclarke gaaclarke approved these changes

@betrevisan betrevisan betrevisan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

affects: examples glfw needs tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bdero @chinmaygarde @gaaclarke @betrevisan