Update license script to ignore NOTICE.fuchsia file #34038
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
tools/licenses/lib/filesystem.dart
Outdated
| case '.fuchsia': | ||
| // Applies to NOTICE.fuchsia file. | ||
| // This is a file that covers things that contribute to the Fuchsia SDK. | ||
| // See: fxb/94240 |
There was a problem hiding this comment.
it would better to skip it by saying we should do so in the main.dart file, in the classes that determine what directories we crawl into
More context at http://fxb/94240
iskakaushik
force-pushed
the
notice-fuchsia
branch
from
3486247 to
6578921
Compare
More context at http://fxb/94240
2 participants
More context at http://fxb/94240