This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[android] Fix leak of bitmap object (android.graphics.Bitmap of Java) while using platform image decoder. #33953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… while using platform image decoder. Change-Id: Ic9187e259191f22273bbee0946173f5e0304c51a
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Change-Id: I07078197985bd8c857905a894721f079b93a15ec
Change-Id: I2e3b88002c1288cbce140ad4af64839b6846f4a0
Change-Id: If8e6dc035d2cead28cc7170e17deb1e4842ea812
chinmaygarde
approved these changes
Jun 16, 2022
jason-simmons
approved these changes
Jun 16, 2022
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 17, 2022
…of Java) while using platform image decoder. (flutter/engine#33953)
jason-simmons
added a commit
to jason-simmons/flutter_engine
that referenced
this pull request
Jun 17, 2022
…ecodeImage This is a follow up to flutter#33953. After that PR, the leak of Java Bitmap objects is still happening because AndroidImageGenerator::DoDecodeImage was not freeing the JNI local reference returned by the invocation of FlutterJNI.decodeImage. This PR fixes that by using a ScopedJavaLocalFrame.
houhuayong
pushed a commit
to houhuayong/engine
that referenced
this pull request
Jun 21, 2022
… while using platform image decoder. (flutter#33953)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[android] Fix leak of bitmap object (android.graphics.Bitmap of Java) while using platform image decoder.
We will use a platform decoder to decode the image that skia not support (such as .heic) and holding a RAW pointer (from new operator) of fml::jni::ScopedJavaGlobalRef. The java bitmap object associated with the RAW pointer is not deleted in all return path.