Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@joshualitt
Copy link
Contributor

This fixes a bug in the method name which can break copy / paste.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Jun 10, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Hixie
Copy link
Contributor

Hixie commented Jun 10, 2022

test-exempt: i am assured that this will be tested in due course, but that it can't be tested right now because of the incremental nature of the migration

@joshualitt joshualitt merged commit 5ef5956 into flutter:main Jun 10, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 10, 2022
CaseyHillers pushed a commit to CaseyHillers/engine that referenced this pull request Jun 10, 2022
CaseyHillers pushed a commit that referenced this pull request Jun 10, 2022
CaseyHillers pushed a commit to CaseyHillers/engine that referenced this pull request Jun 10, 2022
CaseyHillers pushed a commit that referenced this pull request Jun 10, 2022
houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs tests platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants