[dart_test_runner] Stdout/stderr logging to current execution window. #33858
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
naudzghebre
force-pushed
the
dart_runner_fix
branch
from
ad06603 to
18a5057
Compare
|
cc @akbiggs Gentle ping on review? |
shell/platform/fuchsia/dart_runner/dart_test_component_controller_v2.cc
Outdated
Show resolved
Hide resolved
shell/platform/fuchsia/dart_runner/dart_test_component_controller_v2.h
Outdated
Show resolved
Hide resolved
shell/platform/fuchsia/dart_runner/dart_test_component_controller_v2.cc
Outdated
Show resolved
Hide resolved
shell/platform/fuchsia/dart_runner/dart_test_component_controller_v2.h
Outdated
Show resolved
Hide resolved
|
Should add tests before submission per the message above. |
|
From last weeks triage: These patches are blocked on testing. Adding the WIP tag in the meantime. |
… window by passing handles to the dart process and the test_manager.
naudzghebre
force-pushed
the
dart_runner_fix
branch
from
18a5057 to
3441205
Compare
…xecution window by passing handles to the dart process and the test_manager. (flutter/engine#33858)
3 participants
Support stdout/stderr logging to current execution window by passing handles to the dart process and the test_manager.