This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Do not set use_ios_simulator unconditionally
#33855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
suggested changes
Jun 6, 2022
Member
zanderso
left a comment
zanderso
left a comment
There was a problem hiding this comment.
use_ios_simulator defaults to true, and messes up Android builds on mac.
Contributor
Author
|
Ok, I think I figured out what's going on here -updated the |
zanderso
reviewed
Jun 6, 2022
tools/gn
Outdated
| if gn_args['target_os'] == 'ios': | ||
| gn_args['use_ios_simulator'] = args.simulator | ||
| else: | ||
| elif gn_args['target_os'] == 'mac': |
Member
There was a problem hiding this comment.
It's a bit more complicated since you can target Android while on a mac.
Contributor
Author
There was a problem hiding this comment.
But simulator is iOS specific right?
Contributor
Author
|
Filed flutter/flutter#105476 for the infra flakes. |
zanderso
reviewed
Jun 7, 2022
Member
zanderso
left a comment
zanderso
left a comment
There was a problem hiding this comment.
gn_args['host_os'] isn't always filled in apparently.
Co-authored-by: Zachary Anderson <[email protected]>
zanderso
approved these changes
Jun 8, 2022
Member
|
Thanks! |
dnfield
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 8, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 8, 2022
houhuayong
pushed a commit
to houhuayong/engine
that referenced
this pull request
Jun 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zanderso
This causes gn to emit warnings on non-mac platforms