Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@flar
Copy link
Contributor

@flar flar commented Jun 6, 2022

@flar flar requested review from bdero and chinmaygarde June 6, 2022 20:31
@bdero
Copy link
Member

bdero commented Jun 6, 2022

Just to clarify: Other than drawing the filtered texture of the parent layer, SaveLayer ops with a backdrop filter should be treated exactly the same as non-backdrop calls, right? In other words, the layer won't be drawn until restored -- and when it's drawn, it'll respect all of the paint state such as the opacity, blend mode, and filters.

@flar
Copy link
Contributor Author

flar commented Jun 6, 2022

Just to clarify: Other than drawing the filtered texture of the parent layer, SaveLayer ops with a backdrop filter should be treated exactly the same as non-backdrop calls, right? In other words, the layer won't be drawn until restored -- and when it's drawn, it'll respect all of the paint state such as the opacity, blend mode, and filters.

I believe so.

@flar flar added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jun 6, 2022
@fluttergithubbot fluttergithubbot merged commit 0f2870c into flutter:main Jun 6, 2022
@flar
Copy link
Contributor Author

flar commented Jun 6, 2022

Actually, it changes the dimensions of the layer. With no specific clipping it will apply the filter to the entire underlying layer and so the saveLayer layer will be larger to accomodate that.

@bdero
Copy link
Member

bdero commented Jun 6, 2022

Alright perfect, makes sense. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DisplayList does not support backdrop filters

4 participants