This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Use impellerc for engine FragmentProgram unit tests #33824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Jun 5, 2022
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Some nits but otherwise LGTM.
| case TargetPlatform::kFlutterSPIRV: | ||
| spirv_options.SetOptimizationLevel( | ||
| shaderc_optimization_level::shaderc_optimization_level_size); | ||
| shaderc_optimization_level::shaderc_optimization_level_zero); |
Member
Author
There was a problem hiding this comment.
The transpiler is missing some ops: flutter/flutter#105396. Added a comment.
Also it's the level being used by the current test harness:
engine/lib/spirv/test/glsl_to_spirv.cc
Line 39 in d0ec220
| ] | ||
| } | ||
|
|
||
| executable("glsl_to_spirv") { |
Member
There was a problem hiding this comment.
Why can't this entire GN file be removed?
Member
Author
There was a problem hiding this comment.
The program above is still used. It looks like it is used for assembling invalid bytecode to make sure that the transpiler throws errors correctly.
chinmaygarde
changed the title
zanderso
force-pushed
the
impellerc-for-unittests
branch
from
570462a to
7fb0612
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 5, 2022
houhuayong
pushed a commit
to houhuayong/engine
that referenced
this pull request
Jun 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're shipping
impellercto the framework and using it to compile shaders there, that's what we should be using to run the unit tests in the engine repo.