Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@skia-flutter-autoroll skia-flutter-autoroll force-pushed the dart-sdk-flutter-engine-db6173f9-2ad2-4ed6-8b7d-43de5e913416-1654275497 branch from 981f089 to e81c5d4 Compare June 3, 2022 16:58
@skia-flutter-autoroll skia-flutter-autoroll added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jun 3, 2022
@skia-gold
Copy link

Gold has detected about 3 new digest(s) on patchset 1.
View them at https://flutter-engine-gold.skia.org/cl/github/33810

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #33810 at sha e81c5d4

@zanderso
Copy link
Member

zanderso commented Jun 4, 2022

Landing this manually. The gold diffs are related to a different change.

@zanderso zanderso merged commit 8617df2 into flutter:main Jun 4, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 4, 2022
zanderso added a commit to zanderso/engine that referenced this pull request Jun 7, 2022
@skia-flutter-autoroll skia-flutter-autoroll deleted the dart-sdk-flutter-engine-db6173f9-2ad2-4ed6-8b7d-43de5e913416-1654275497 branch June 10, 2022 17:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. will affect goldens

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants