This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Roll Dart SDK from 5d44fae9a591 to 38f740a60f4c (1 revision) #33810
Merged
zanderso
merged 1 commit into
flutter:main
from
skia-flutter-autoroll:dart-sdk-flutter-engine-db6173f9-2ad2-4ed6-8b7d-43de5e913416-1654275497
Jun 4, 2022
Merged
Roll Dart SDK from 5d44fae9a591 to 38f740a60f4c (1 revision) #33810
zanderso
merged 1 commit into
flutter:main
from
skia-flutter-autoroll:dart-sdk-flutter-engine-db6173f9-2ad2-4ed6-8b7d-43de5e913416-1654275497
Jun 4, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://dart.googlesource.com/sdk.git/+log/5d44fae9a591..38f740a60f4c 2022-06-03 dart-internal-sdk-dev-roller@dart-ci-internal.iam.gserviceaccount.com Version 2.18.0-168.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
981f089 to
e81c5d4
Compare
|
Gold has detected about 3 new digest(s) on patchset 1. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
zanderso
approved these changes
Jun 4, 2022
Member
|
Landing this manually. The gold diffs are related to a different change. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2022
houhuayong
pushed a commit
to houhuayong/engine
that referenced
this pull request
Jun 21, 2022
https://dart.googlesource.com/sdk.git/+log/5d44fae9a591..38f740a60f4c 2022-06-03 dart-internal-sdk-dev-roller@dart-ci-internal.iam.gserviceaccount.com Version 2.18.0-168.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
waiting for tree to go green
This PR is approved and tested, but waiting for the tree to be green to land.
will affect goldens
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dart.googlesource.com/sdk.git/+log/5d44fae9a591..38f740a60f4c
2022-06-03 dart-internal-sdk-dev-roller@dart-ci-internal.iam.gserviceaccount.com Version 2.18.0-168.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md