This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add versions to all the dependencies so they are pinned. #33784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyHillers
approved these changes
Jun 2, 2022
Contributor
|
Tree is red. Once https://flutter-dashboard.appspot.com/#/build?repo=engine&branch=main goes green, you'll need to rebase this PR with upstream/main. |
Contributor
Author
|
Thank you Casey! I will make those changes. |
ricardoamador
force-pushed
the
validate_ci_yaml_deps_pinned
branch
from
efa05df to
77a8aaf
Compare
keyonghan
approved these changes
Jun 2, 2022
Contributor
keyonghan
left a comment
keyonghan
left a comment
There was a problem hiding this comment.
LGTM. You can add the waiting for tree to go green label to have the bot auto submit.
Contributor
Author
|
Oh cool I did not know that. Thanks Keyong! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 3, 2022
houhuayong
pushed a commit
to houhuayong/engine
that referenced
this pull request
Jun 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of The Issue Being Addressed
The builder config is fragile when dependencies are not pinned to specific versions. Any upstream changes may cause breakage. We should create a test to validate all .ci.yaml dependencies are pinned. This also requires that we pin specific versions for all dependencies.
Issues Addressed
flutter/flutter#101712
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.