This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Linux] take first steps towards testable text input #33661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows passing an offscreen window for testing purposes.
Keep track of registered message handlers and allow tests to simulate receiving messages.
8 tasks
cbracken
approved these changes
May 31, 2022
Member
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
lgtm with a minor suggestion.
Member
|
Looks like there's a legitimate test failure to fix in |
Member
|
@jpnurmi Any updates on the test failures? |
GdkOffscreenWindow requires display & screen which is a problem in headless mode. Luckily, we don't really need a window instance in tests because its only passed as a client window to the IM context which will be mocked out when we get to tests that depend on it.
Member
Author
|
I was silly and ignored the harmless warnings from GdkWindow but the warnings would become a problem when made fatal. Luckily, we don't really need a window instance in the text input tests because it's only passed as a client window to the IM context which will be mocked out when we get to tests that depend on it. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 10, 2022
houhuayong
pushed a commit
to houhuayong/engine
that referenced
this pull request
Jun 21, 2022
This PR is a continuation of flutter#33111 and includes necessary changes to test the `TextInputType.setClient()` platform channel call. Testing the actual text input flow requires a mock IM context that will follow in a separate PR. * [Linux] pass GdkWindow instead of FlView to FlTextInputPlugin * [Linux] add MockBinaryMessenger::ReceiveMessage() * [Linux] add test for TextInputType.setClient * Drop the offscreen window GdkOffscreenWindow requires display & screen which is a problem in headless mode. Luckily, we don't really need a window instance in tests because its only passed as a client window to the IM context which will be mocked out when we get to tests that depend on it.
Member
Author
|
I've pushed the next step: #34186 |
cbracken
pushed a commit
that referenced
this pull request
Jun 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #33111 and includes necessary changes to test the
TextInputType.setClient()platform channel call. Testing the actual text input flow requires a mock IM context that will follow in a separate PR.Pre-launch Checklist
///).