This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] GLES: Wire up program link log dumping and fix TheImpeller showcase. #33626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… showcase. The linker error was due to the same uniform name with different types appearing in different shader stages. I'll add an Impeller validation for this in a subsequent patch so we don't depend on testing in GLES. There was also another issue related to not being able to bind a cube-map type texture. After these fixes, the showcase runs but the one of the textures doesn't seem to be sampled still. But still, the progress is pretty neat. Fixes flutter/flutter#104585
bdero
approved these changes
May 25, 2022
Member
bdero
left a comment
bdero
left a comment
There was a problem hiding this comment.
Awesome, thanks for making it work!
chinmaygarde
added
waiting for tree to go green
Member
Author
|
Minor change: Replaced std::max with std::min when calculating log buffer length. |
chinmaygarde
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 26, 2022
…Impeller showcase. (flutter/engine#33626)
houhuayong
pushed a commit
to houhuayong/engine
that referenced
this pull request
Jun 21, 2022
… showcase. (flutter#33626) The linker error was due to the same uniform name with different types appearing in different shader stages. I'll add an Impeller validation for this in a subsequent patch so we don't depend on testing in GLES. There was also another issue related to not being able to bind a cube-map type texture. After these fixes, the showcase runs but the one of the textures doesn't seem to be sampled still. But still, the progress is pretty neat. Fixes flutter/flutter#104585.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linker error was due to the same uniform name with different types
appearing in different shader stages. I'll add an Impeller validation
for this in a subsequent patch so we don't depend on testing in GLES.
There was also another issue related to not being able to bind a
cube-map type texture.
After these fixes, the showcase runs but the one of the textures
doesn't seem to be sampled still. But still, the progress is pretty
neat.
Fixes flutter/flutter#104585
