Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[impeller] Include <functional> in a header file where std::function is used. #33621

Merged
fluttergithubbot merged 2 commits into from
May 25, 2022
Merged

[impeller] Include <functional> in a header file where std::function is used. #33621

fluttergithubbot merged 2 commits into from
May 25, 2022

Conversation

@chingjun
Copy link
Contributor

@chingjun chingjun commented May 25, 2022

Fix internal build.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@chingjun chingjun requested a review from chinmaygarde May 25, 2022 20:28
chinmaygarde
chinmaygarde suggested changes May 25, 2022
View reviewed changes
Copy link
Member

@chinmaygarde chinmaygarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely you mean <functional>?

@chingjun
Copy link
Contributor Author

chingjun commented May 25, 2022

You're right. I was thinking about the fractional flutter_tester when I was writing this.

@chingjun chingjun changed the title [impeller] Include <fractional> in a header file where std::function is used. [impeller] Include <functional> in a header file where std::function is used. May 25, 2022
@chingjun chingjun added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 25, 2022
@fluttergithubbot fluttergithubbot merged commit 480610c into flutter:main May 25, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 25, 2022
@engine-flutter-autoroll
480610c [impeller] Include <functional> in a header file where std::f…
2b4480f 
…unction is used. (flutter/engine#33621)
houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
@chingjun @houhuayong
[impeller] Include <functional> in a header file where std::function …
53236d5 
…is used. (flutter#33621)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@chinmaygarde chinmaygarde chinmaygarde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

e: impeller waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chingjun @chinmaygarde @fluttergithubbot