This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Pass the --enable-skparagraph=false flag if the EnableSkParagraph manifest metadata value is false #33597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ifest metadata value is false Without this, apps would need to explicitly pass an --enable-skparagraph=false flag to the shell in addition to disabling SkParagraph in the manifest.
chinmaygarde
approved these changes
May 25, 2022
jason-simmons
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 25, 2022
…raph manifest metadata value is false (flutter/engine#33597)
jason-simmons
added a commit
to jason-simmons/flutter_engine
that referenced
this pull request
Jun 1, 2022
…ifest metadata value is false (flutter#33597)
houhuayong
pushed a commit
to houhuayong/engine
that referenced
this pull request
Jun 21, 2022
…ifest metadata value is false (flutter#33597)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, apps would need to explicitly pass an --enable-skparagraph=false
flag to the shell in addition to disabling SkParagraph in the manifest.