Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented May 24, 2022

Reverts #33567

Just realized I didn't check the g3 full result yesterday and it turns out there are multiple errors left. Sorry about the back and forth.

@flutter-dashboard flutter-dashboard bot added embedder Related to the embedder API platform-android labels May 24, 2022
@dkwingsmt dkwingsmt requested a review from gspencergoog May 24, 2022 17:25
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@dkwingsmt dkwingsmt added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 24, 2022
@dkwingsmt dkwingsmt merged commit 789b554 into main May 24, 2022
@dkwingsmt dkwingsmt deleted the revert-33567-reland-android-key-embedder-responder branch May 24, 2022 18:02
houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

embedder Related to the embedder API platform-android waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants