Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@nbayati
Copy link
Contributor

@nbayati nbayati commented May 23, 2022

Move the implementation of AccessibilityFeatures class to the engine and create a copyWith function so we can update each feature individually. Previously all the features were disabled without any option to enable them. Now when semantics gets enabled/disabled we'll also update the value of accessibleNavigation to reflect the current state.

Fixes flutter/flutter#67571

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label May 23, 2022
@nbayati nbayati requested a review from yjbanov May 24, 2022 00:05
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nbayati nbayati added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 24, 2022
@fluttergithubbot fluttergithubbot merged commit 1c655a4 into flutter:main May 24, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 24, 2022
@nbayati nbayati deleted the media-query-a11y branch June 1, 2022 17:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

platform-web Code specifically for the web engine waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MediaQuery.of(context).accessibleNavigation does not work on flutter web

3 participants