Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@christopherfujino
Copy link
Contributor

Reland of #33345. I reverted it to try to workaround flutter/flutter#104387, however the CIPD download was never the issue, but rather that test runs of the codesigning script were signing these binaries after they were uploaded.

Fixes flutter/flutter#95209

@christopherfujino christopherfujino added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 23, 2022
@fluttergithubbot fluttergithubbot merged commit d9af583 into main May 24, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 24, 2022
@christopherfujino christopherfujino deleted the revert-33558-revert-33345-dart-sdk-cipd branch May 24, 2022 17:48
houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove download_dart_sdk.py and use CIPD instead.

3 participants