This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland Enable MSAA behind a flag for iOS #33505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
added
the
waiting for tree to go green
dnfield
commented
May 20, 2022
Comment on lines
+47
to
+48
| auto surface = std::make_unique<GPUSurfaceMetalSkia>(this, main_context_, MsaaSampleCount::kNone, | ||
| render_to_surface); |
Contributor
Author
There was a problem hiding this comment.
Specifically, in the previous version of this patch I wrote
auto surface = std::make_unique<GPUSurfaceMetalSkia>(this, main_context_, render_to_surface, 1);Which meant render_to_surface was always true, which is the wrong thing to do (and caused the blank screen rendering).
Contributor
Author
There was a problem hiding this comment.
Using the enum everywhere means that wouldn't even compile now.
| return weak_factory->GetWeakPtr(); | ||
| } | ||
|
|
||
| - (void)testMsaaSampleCount { |
Contributor
There was a problem hiding this comment.
Test needs to be updated to use the enum
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
dnfield
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 20, 2022
houhuayong
pushed a commit
to houhuayong/engine
that referenced
this pull request
Jun 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relands #33461
The patch was previously reverted because of a mistake in the embedder code: I had transposed the position of the
render_to_surfaceargument and themsaa_samplesargument, and C++ did an implicit int to bool conversion which broke everything on desktop.I've manually verified that desktop works, and I've switched to using an enum everywhere for the MSAA sample count argument so that the type error won't happen again.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.