Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@yusuf-goog
Copy link
Contributor

@yusuf-goog yusuf-goog commented May 19, 2022

Bug:102406

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@godofredoc godofredoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's send a PSA indicating this is happening now.

Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yusuf-goog
Copy link
Contributor Author

Let's send a PSA indicating this is happening now.

Sent already with expected time windows.

@yusuf-goog yusuf-goog added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 20, 2022
@yusuf-goog yusuf-goog self-assigned this May 20, 2022
@fluttergithubbot fluttergithubbot merged commit cb9ed1f into main May 20, 2022
@yusuf-goog yusuf-goog deleted the gobuntu branch May 20, 2022 00:51
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 20, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 20, 2022
godofredoc added a commit that referenced this pull request May 24, 2022
* 'Update Dart SDK to a6465a4'

* Swap engine builds from Debian to Ubuntu. (#33498)

* Update licenses hash.

* Remove Windows UWP Engine target (#33012)

Removes the Windows UWP Engine target from CI.

UWP support was removed from the tool in:
https://flutter-review.googlesource.com/c/recipes/+/29500

UWP support will be removed from the recipe in:
https://flutter-review.googlesource.com/c/recipes/+/29500

UWP infra will be removed in a future patch.

Issue: flutter/flutter#102172

* WinUWP: remove uses of build_windows_uwp (#33015)

Co-authored-by: yusuf-goog <[email protected]>
Co-authored-by: Chris Bracken <[email protected]>
houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants