Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Windows] Unused include cleanup in ViewController #33466

Merged
cbracken merged 1 commit into from
May 18, 2022
Merged

[Windows] Unused include cleanup in ViewController #33466

cbracken merged 1 commit into from
May 18, 2022

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented May 18, 2022 •
edited
Loading

Eliminates two unused includes in the client wrapper view controller
header. These were introduced in 51a376d and 709fc6e, usage was
deprecated in cd4192d and removed in 4eb069f.

No test since no semantic changes, just removal of #includes that
no longer are used in this file.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken
[Windows] Unused include cleanup in ViewController
f64be44 
Eliminates two unused includes in the client wrapper view controller
header. These were introduced in 51a376d and 709fc6e, usage was
deprecated in cd4192d and removed in 4eb069f.

No test changes since no semantic changes; just the removal of
header #includes that are no longer used in this file.
@cbracken cbracken requested a review from stuartmorgan-g May 18, 2022 20:40
@cbracken cbracken merged commit 6a8732c into flutter:main May 18, 2022
@cbracken cbracken deleted the header-cleanup branch May 18, 2022 21:34
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2022
@engine-flutter-autoroll
6a8732c [Windows] Unused include cleanup in ViewController (flutter/e…
e3fba60 
…ngine#33466)
houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
@cbracken @houhuayong
[Windows] Unused include cleanup in ViewController (flutter#33466)
64a4e69 
Eliminates two unused includes in the client wrapper view controller
header. These were introduced in 51a376d and 709fc6e, usage was
deprecated in cd4192d and removed in 4eb069f.

No test changes since no semantic changes; just the removal of
header #includes that are no longer used in this file.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform-windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cbracken @stuartmorgan-g