[dart_component][hello_world] Add a hello world dart component. #33465
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
…wing PRs will incorporate this in an integration test
naudzghebre
force-pushed
the
dart_component
branch
from
eec9918 to
64fd749
Compare
| { | ||
| program: { | ||
| data: "data/hello_world", | ||
| runner: "dart_jit_runner" |
There was a problem hiding this comment.
We don't specify the runner explicitly for the Flutter runner integration test so I wonder if this will create problems for you later, but I don't see any problem with specifying it explicitly. The only downside I can see is that you won't be able to run this component manually on release builds for example.
There was a problem hiding this comment.
I can change it in following PRs, it was asking for a runner to be listed when building.
|
|
||
| group("tests") { | ||
| testonly = true | ||
| deps = [ "hello_world:hello_world_dart" ] |
There was a problem hiding this comment.
This is fine for now to build our target, but hello_world_dart should eventually become a dependency of our startup test instead of a dependency of the tests group (since it's not a unit test itself).
There was a problem hiding this comment.
Yep, just kept it around to get it building.
…t. Following PRs will incorporate this in an integration test (flutter/engine#33465)
…wing PRs will incorporate this in an integration test (flutter#33465)
2 participants
[dart_component][hello_world] Add a hello world dart component.