Exclude Skia's 'bazel' directory from traversal by the license script #33426
Conversation
It contains only bazel build files, which Flutter doesn't use, and which can't end up in the final binary.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
zanderso
added
the
waiting for tree to go green
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
|
This is going to struggle to land until there's a lull in Skia rolls. |
|
Temporarily pause the skin roller? |
|
I've paused the Skia autoroller to try to get this landed. FYI @GaryQian who is the sheriff this week. |
…flutter#33426) * Exclude Skia's 'bazel' directory from traversal by the license script It contains only bazel build files, which Flutter doesn't use, and which can't end up in the final binary. * Update license file * Update tool_signature * Update skia license hash * Update tool_signature * Update licenses_skia * Update licenses_skia
3 participants
It contains only bazel build files, which Flutter doesn't use, and which can't end up in the final binary.