This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Set error handler #33402
Merged
Set error handler #33402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
akbiggs
approved these changes
May 16, 2022
jaeheon
force-pushed
the
set-error-handler
branch
from
9e34ddc to
f2ebe42
Compare
jaeheon
force-pushed
the
set-error-handler
branch
from
f2ebe42 to
f465fde
Compare
jaeheon
added
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 17, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 17, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 17, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 17, 2022
jonahwilliams
pushed a commit
to flutter/flutter
that referenced
this pull request
May 17, 2022
* e0f736d Set error handler (flutter/engine#33402) * dcd596a Roll Dart SDK from 381855557df2 to f3bf9025c141 (1 revision) (flutter/engine#33411) * 5c2a16e Roll Fuchsia Linux SDK from F0_B8WVKY... to IZ7_b83xC... (flutter/engine#33415) * 4958a24 Roll dart sdk to 1bdb83bddf96c41cc046810c697a2c80bfaaaf19 (flutter/engine#33416) * d2fd3d8 Roll Fuchsia Mac SDK from t_ky8l6nb... to egBfZMmTP... (flutter/engine#33417) * d58fc83 Roll Dart SDK from 1bdb83bddf96 to 0bc104c3e959 (1 revision) (flutter/engine#33419) * 8ab1720 Roll Skia from 0a5146ca3ffd to 16fa353926b8 (28 revisions) (flutter/engine#33420) * Remove fraction translation * Update codesign.dart Co-authored-by: Jonah Williams <[email protected]>
houhuayong
pushed a commit
to houhuayong/engine
that referenced
this pull request
Jun 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call SetErrorHandler on TouchSource and MouseSource channels, with a log message about channel closure.
flutter/flutter#103928
Pre-launch Checklist
writing and running engine tests.
///).