This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Migrate Flutter Web DOM usage to JS static interop - 24. #33352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
|
Gold has detected about 5 new digest(s) on patchset 14. |
joshualitt
force-pushed
the
html_24
branch
3 times, most recently
from
f16fc3d to
51be526
Compare
|
This pull request is not mergeable in its current state, likely because of a merge conflict. Pre-submit CI jobs were not triggered. Pushing a new commit to this branch that resolves the issue will result in pre-submit jobs being scheduled. |
joshualitt
force-pushed
the
html_24
branch
2 times, most recently
from
7d47875 to
a0c3db5
Compare
Contributor
Author
|
Okay rebased, ptal |
eyebrowsoffire
approved these changes
Jun 7, 2022
Contributor
eyebrowsoffire
left a comment
eyebrowsoffire
left a comment
There was a problem hiding this comment.
One small thing, but not a blocker.
joshualitt
force-pushed
the
html_24
branch
3 times, most recently
from
7af4340 to
789b881
Compare
Contributor
Author
|
@eyebrowsoffire Just a heads up, I needed to land some fixes to the url_strategy because they seemed to break Flutter. Hopefully I found all of the places I needed to fix to land this CL. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 9, 2022
houhuayong
pushed a commit
to houhuayong/engine
that referenced
this pull request
Jun 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is CL 24 in a series of CLs to migrate Flutter Web DOM usage to the new JS static interop API.