Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@joshualitt
Copy link
Contributor

This is CL 20 in a series of CLs to migrate Flutter Web DOM usage to the new JS static interop API.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label May 14, 2022
@skia-gold
Copy link

Gold has detected about 5 new digest(s) on patchset 10.
View them at https://flutter-engine-gold.skia.org/cl/github/33348

@joshualitt joshualitt marked this pull request as ready for review May 18, 2022 21:52
@joshualitt joshualitt requested a review from yjbanov May 18, 2022 21:52
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #33348 at sha 797edd3

Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joshualitt joshualitt force-pushed the html_20 branch 2 times, most recently from 7bba3e2 to 4b01114 Compare May 26, 2022 00:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

platform-web Code specifically for the web engine will affect goldens

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants