This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Use CIPD to download prebuilt Dart SDKs #33345
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
See comment here for caveats: flutter/flutter#95209 (comment) |
Contributor
Yeah this will definitely break the new archiving system. Can we update the dart-sdk target to zip the content from the cipd location? |
40bf5f3 to
8ab8279
Compare
Member
Author
|
@godofredoc I updated to create the archive. PTAL. |
jason-simmons
approved these changes
May 17, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 17, 2022
godofredoc
reviewed
May 18, 2022
Contributor
godofredoc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
christopherfujino
added a commit
that referenced
this pull request
May 23, 2022
This reverts commit 051eee8.
christopherfujino
added a commit
that referenced
this pull request
May 23, 2022
christopherfujino
added a commit
that referenced
this pull request
May 23, 2022
fluttergithubbot
pushed a commit
that referenced
this pull request
May 24, 2022
This was referenced Jun 2, 2022
houhuayong
pushed a commit
to houhuayong/engine
that referenced
this pull request
Jun 21, 2022
houhuayong
pushed a commit
to houhuayong/engine
that referenced
this pull request
Jun 21, 2022
…tter#33558) This reverts commit 051eee8.
houhuayong
pushed a commit
to houhuayong/engine
that referenced
this pull request
Jun 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: flutter/flutter#95209