This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Fix text field actions not triggered on Android #33298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
ditman
approved these changes
May 12, 2022
| String getEditingInputMode() { | ||
| return textEditing!.strategy.domElement!.getAttribute('inputmode')!; | ||
| String? getEditingInputMode() { | ||
| return textEditing!.strategy.domElement!.getAttribute('inputmode'); |
Member
There was a problem hiding this comment.
.inputMode? https://api.dart.dev/stable/2.9.1/dart-html/Element/inputMode.html (non-nullable, wow, should we report this as a dart:html bug?)
Contributor
Author
There was a problem hiding this comment.
Nice find! I didn't know about that one, but it definitely should be nullable.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 14, 2022
houhuayong
pushed a commit
to houhuayong/engine
that referenced
this pull request
Jun 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
inputmodeattribute is useful in mobile browsers to display the correct type of keyboard (e.g. numbers, email, etc).For plain text input, we can either omit the
inputmodeattribute or useinputmode="text"(which corresponds to the default value). But in Android Chrome, usinginputmode="text"causes the text field to not send the rightkeyCodeforENTER.The fix is to omit
inputmodein plain text fields.Fixes flutter/flutter#89384